Discussion:
Sort definition-prefixes?
(too old to reply)
Glenn Morris
2018-04-19 00:41:35 UTC
Permalink
Hi,

Should definition prefixes be sorted to prevent meaningless churn like
in http://lists.gnu.org/r/emacs-diffs/2018-04/msg00007.html ?
Or is the frequency (?) order that they are now in useful for anything?

--- a/lisp/emacs-lisp/autoload.el
+++ b/lisp/emacs-lisp/autoload.el
@@ -607,7 +607,8 @@ autoload--make-defs-autoload
nil))))
prefixes)))
`(if (fboundp 'register-definition-prefixes)
- (register-definition-prefixes ,file ',(delq nil strings)))))))
+ (register-definition-prefixes ,file ',(sort (delq nil strings)
+ 'string<)))))))
Stefan Monnier
2018-04-19 12:43:43 UTC
Permalink
Post by Glenn Morris
Should definition prefixes be sorted to prevent meaningless churn like
in http://lists.gnu.org/r/emacs-diffs/2018-04/msg00007.html ?
Yes, please.
Post by Glenn Morris
Or is the frequency (?) order that they are now in useful for anything?
I don't think they're currently in any meaningful order like frequency.


Stefan

Loading...