Discussion:
Releasing Emacs 26.1
(too old to reply)
Eli Zaretskii
2018-05-06 19:52:15 UTC
Permalink
Any objections to releasing Emacs 26.1 in a week's time, anyone?
Alan Third
2018-05-06 21:00:13 UTC
Permalink
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
None from me as long as I can apply the attached patch for a crash bug
I just discovered this evening.
--
Alan Third
Basil L. Contovounesios
2018-05-07 01:21:05 UTC
Permalink
Post by Alan Third
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
None from me as long as I can apply the attached patch for a crash bug
I just discovered this evening.
Which, to the completely untrained eye, looks like it would go nicely
with bug#31373.
--
Basil
Basil L. Contovounesios
2018-05-07 12:46:36 UTC
Permalink
Post by Basil L. Contovounesios
Post by Alan Third
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
None from me as long as I can apply the attached patch for a crash bug
I just discovered this evening.
Which, to the completely untrained eye, looks like it would go nicely
with bug#31373.
It’s similar, but different. I actually only found it because I went
to check I hadn’t made a similar mistake, though.
My case only crashes if there’s a tooltip showing when the function
runs, because on NS tooltips are full‐blown NSWindows, but not Emacs
frames.
Indeed; I meant only that it would be nice to have both issues fixed in
the same Emacs release, seeing as they materialise in similar functions.
--
Basil
Eli Zaretskii
2018-05-07 17:42:55 UTC
Permalink
Date: Sun, 6 May 2018 22:00:13 +0100
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
None from me as long as I can apply the attached patch for a crash bug
I just discovered this evening.
If you are reasonably sure this change cannot be worse than the bug it
attempts to fix, it's fine with me to push to the release branch.

Thanks.
Phil Sainty
2018-05-07 00:13:51 UTC
Permalink
I was imagining there'd be a rc2 before the release so that more
people could confirm fixes made to rc1; but I don't have a feel for
the number and status/severity of bug reports and fixes made, so
I don't have any particular justification / objection.

#31355 is the only thing I'm involved in that I'd want to ensure
was included as, while it's minor, it's a regression from 25.
I need to follow up on Michael's last reply, but I can certainly
do that this week.

-Phil
Michael Albinus
2018-05-07 07:32:02 UTC
Permalink
Phil Sainty <***@orcon.net.nz> writes:

Hi Phil,
Post by Phil Sainty
#31355 is the only thing I'm involved in that I'd want to ensure
was included as, while it's minor, it's a regression from 25.
I need to follow up on Michael's last reply, but I can certainly
do that this week.
I don't see that this bug is a release stopper. In comparision, there
are more severe Tramp bugs I didn't commit to the release branch in
order to not destabilize it. They are waiting for Emacs 26.2.
Post by Phil Sainty
-Phil
Best regards, Michael.
Michael Albinus
2018-05-07 11:29:39 UTC
Permalink
Phil Sainty <***@orcon.net.nz> writes:

Hi Phil,
If the bugs are in new functionality, I wouldn't see any issue with
leaving the improvements until the next release if necessary; but
I would have thought known regressions to behaviour which was working
properly in the previous stable release would be worth delaying the
new release to fix, if necessary.
I suppose I don't understand why there's any hurry to release 26.1.
Because it wouldn't be released ever, otherwise. The Emacs bug tracker
contains 1742 open bugs in state "serious,important,normal" as of
today. I bet there are many open bugs we could apply the same reasoning
as you have given above.

Emacs 26.1 is in code-freeze. Bug#31355 does not block Emacs 26.1, and a
workaround (your patch) does exist. So I don't believe this bug shall
stop the release.

But I'm neither the maintainer nor the release manager, which will
decide. Eli? John? Nico?
-Phil
Best regards, Michael.
Nicolas Petton
2018-05-07 15:08:42 UTC
Permalink
Post by Michael Albinus
But I'm neither the maintainer nor the release manager, which will
decide. Eli? John? Nico?
I agree, but Eli and John should decide.

Cheers,
Nico
Eli Zaretskii
2018-05-07 18:09:22 UTC
Permalink
Date: Mon, 07 May 2018 13:29:39 +0200
I suppose I don't understand why there's any hurry to release 26.1.
Because it wouldn't be released ever, otherwise.
Right, there's always one more bug.
Van L
2018-05-07 11:44:26 UTC
Permalink
If the bugs are in new functionality, I wouldn't see any issue with
leaving the improvements until the next release if necessary;
In org mode for Emacs 26.1 rc-1, I see comment alignment for cpp not lining up, see screenshot.

Loading Image...

The problem line has `int i = 7;’.

Its comment isn’t lining up with the one line above and the two below.

`M-x align-regexp’ on `//‘ was applied to the four lines not in the zoomed in (C-c ‘) abbrev view. Then, going into the abbrev view sees the alignment not lining up.
Bastien
2018-05-07 12:05:40 UTC
Permalink
Hi,
Post by Van L
If the bugs are in new functionality, I wouldn't see any issue with
leaving the improvements until the next release if necessary;
In org mode for Emacs 26.1 rc-1, I see comment alignment for cpp not
lining up, see screenshot.
I cannot reproduce this bug with Emacs 26.1 rc-1 and Org 9.1.12.

Can you send it to emacs-***@gnu.org and provide a detailed recipe
on how to reproduce it with emacs -Q?

Thanks,
--
Bastien
Eli Zaretskii
2018-05-07 18:08:33 UTC
Permalink
Date: Mon, 07 May 2018 23:10:57 +1200
I suppose I don't understand why there's any hurry to release 26.1.
There's no hurry. Which is why we were pretesting it since the last
September. At some point we'd like to actually release it. (I
originally hoped to be able to do that much earlier, around December.)
Eli Zaretskii
2018-05-07 17:44:12 UTC
Permalink
Date: Mon, 07 May 2018 12:13:51 +1200
#31355 is the only thing I'm involved in that I'd want to ensure
was included as, while it's minor, it's a regression from 25.
I need to follow up on Michael's last reply, but I can certainly
do that this week.
AFAIU, there's no agreed-to solution yet, so it's premature to discuss
whether it can be pushed to emacs-26.
Bastien
2018-05-07 05:40:37 UTC
Permalink
Hi Eli,
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
If these four Org bugfixes (9.1.13) can make it, that'd be great:

064caac ox-html: Make use of :html-preamble/postamble-format
631c4b7 org-src: Clear overlay in Org buffer after major mode change
80eb69b org-list: Proper error message when trying to indent top level item
388254e Revert "org.el: Fix bug when links contain special characters"

Not a stopper, though.

Thanks everyone for all the hard work -- and congrats!
--
Bastien
Eli Zaretskii
2018-05-07 19:05:38 UTC
Permalink
Date: Mon, 07 May 2018 07:40:37 +0200
064caac ox-html: Make use of :html-preamble/postamble-format
631c4b7 org-src: Clear overlay in Org buffer after major mode change
80eb69b org-list: Proper error message when trying to indent top level item
388254e Revert "org.el: Fix bug when links contain special characters"
The last 2 are okay for the release branch. The other two I'm not
comfortable enough to risk, sorry. (They don't seem ti be critical,
are they?)

Thanks.

John Wiegley
2018-05-07 05:30:19 UTC
Permalink
Post by Eli Zaretskii
Any objections to releasing Emacs 26.1 in a week's time, anyone?
None at all! Congrats.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
Loading...